gateway: add configurable DNS TXT resolve timeout #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new `dns_resolve` timeout setting in the proxy timeouts config to prevent DNS TXT record lookups from hanging indefinitely when resolving app addresses. Default timeout is 5 seconds, configurable via gateway.toml: [core.proxy.timeouts] dns_resolve = "5s"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a configurable timeout for DNS TXT record resolution when looking up app addresses. This prevents the gateway from hanging indefinitely when DNS resolution is slow or unresponsive.
Changes
dns_resolvetimeout setting toTimeoutsconfig structresolve_app_addresscall inproxy_with_sniConfiguration
Test plan